grunt build fails with node 8
spadgett opened this issue · comments
I ran npm install before grunt build.
Might be related to #133
$ grunt build
>> Local Npm module "grunt-cli" not found. Is it installed?
Loading "grunt-karma.js" tasks...ERROR
>> TypeError: Cannot read property 'prototype' of undefined
Running "build" task
Running "clean:all" (clean) task
Cleaning "dist/less"...OK
Cleaning "dist/origin-web-common-services.js"...OK
Cleaning "dist/origin-web-common-ui.js"...OK
Cleaning "dist/origin-web-common.css"...OK
Cleaning "dist/origin-web-common.js"...OK
Cleaning "dist/origin-web-common.min.js"...OK
Cleaning "dist/scripts"...OK
Running "ngtemplates:dist" (ngtemplates) task
File dist/scripts/templates.js created.
Running "concat:ui" (concat) task
File "dist/origin-web-common-ui.js" created.
Running "concat:services" (concat) task
File "dist/origin-web-common-services.js" created.
Running "concat:dist" (concat) task
File "dist/origin-web-common.js" created.
Running "copy:main" (copy) task
Copied 12 files
Running "ngAnnotate:dist" (ngAnnotate) task
>> 1 file successfully generated.
Running "less:production" (less) task
>> 1 stylesheet created.
Running "uglify:build" (uglify) task
File "dist/origin-web-common.min.js" created.
Warning: Task "karma" not found. Use --force to continue.
Aborted due to warnings.
cc @cdcabrera
This might be because I'm using node 8
Working OK for me, node 6.8.1
@jeff-phillips-18 thanks, lowering the severity since it's appears to be specific to node 8.
I thought we needed to stick with something like node v4.x to match what origin-console uses?
Yeah, I'm on Node 6.10.2, seems to be ok... I can take a bit more of an in depth look
I thought we needed to stick with something like node v4.x to match what origin-console uses?
It's not required for origin-web-console anymore. See openshift/origin-web-console#1667
@cdcabrera already downgraded for now :/
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale