Consider adding go.mod replace statements and use imports instead of copied code

Question

Consider adding go.mod replace statements and use imports instead of copied code

kaovilai opened this issue 6 months ago · comments

Tiger Kaovilai commented 6 months ago

There are several functions that were copied into this repo from other repos for reasons such as

private functions
package containing function imports incompatible go.mod dependency that would have required go.mod replace statements to remedy

We want to eliminate functions that could be imported even if it means adding replace statements provided

the replace uses version openshift/velero uses.
it does not create cyclic import at the package level (go should prevent this anyway)

Instances of package containing function imports incompatible go.mod dependency

func GetBucketRegion(bucket string) from openshift-velero-plugin
func LeaderElectionDefaulting(config configv1.LeaderElection, defaultNamespace, defaultName string) configv1.LeaderElection from openshift/library-go

private functions/structs copied code

velero server args

Priority: eliminate team's own repos copied code first. Ideally source repo would also import the same k8s deps the same version velero uses so replace statements are more avoidable.

Mateus Oliveira · Answer 1 · Thu Feb 22 2024 02:48:55 GMT+0800 (China Standard Time)

adding this PR for future insights about how to fix the problem https://github.com/shubham-pampattiwar/oadp-operator/pull/1/files

OpenShift Bot · Answer 2 · Wed May 22 2024 09:00:30 GMT+0800 (China Standard Time)

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

OpenShift Bot · Answer 3 · Fri Jun 21 2024 16:30:35 GMT+0800 (China Standard Time)

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

OpenShift Bot · Answer 4 · Mon Jul 22 2024 08:00:36 GMT+0800 (China Standard Time)

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · Answer 5 · Mon Jul 22 2024 08:01:28 GMT+0800 (China Standard Time)

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.