Codecov job
mateusoliveira43 opened this issue · comments
Codecov job has been down for some time (I believe because we use latest release and there is no indication that job failed, it was fixed here #1255)
Since Codecov has a pull requests tab, I think would be nice to add it (back) to pull request CI jobs, and I think there is no necessity to add it to periodic CI run, since it will have the same result as last post CI run
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
/remove-lifecycle stale
/lifecycle frozen
Check in upstream repositories how this is done for pull requests
Another option is to use Go tools in pull requests (or even just use it, removing Codecov)
Example:
# generate profile as we already do
go test $(go list ./... | grep -v /e2e) -coverprofile cover.out
# to get general test coverage result of the poroject
go tool cover -func=cover.out
# to see which parts of the code are not covered
go tool cover -html=cover.outProblem around this approach is that Go 1.22+ gives more correct test coverage results, so would need to update GO version for a reliable result
@mateusoliveira43 Velero upstream is currently in the process of moving to go 1.22, so that means the next rebase after this happens will require us to use 1.22 for Velero and plugin forks anyway. So since we have to move to 1.22 anyway, it sounds like that resolves problems in oadp-operator here as well.