Giters

openshift / cluster-logging-operator

Operator to support logging subsystem of OpenShift

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature request: enabling affinity rules for fluentds

m-yosefpor opened this issue · comments

commented

Right now it is possible to define a nodeSelector for fluentd daemonSets via .spec.collection.logs.fluentd.nodeSelector in ClusterLogging, however, more complex affinity rules such as the following is not currently possible:

      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: node-role.kubernetes.io/worker
                operator: Exists
              - key: node-role.kubernetes.io/infra
                operator: DoesNotExist

P.S.1: This can be also added to other components (es, kibana, .. ) as well.
P.S.2: I'm willing to contribute a PR for this if the feature matches the project guidelines.

commented

@alanconway thoughts on adding this feature? @sichvoge should we move this to a more formal location for tracking (e.g. issues.redhat.com)

commented

@m-yosefpor can you raise this as a "Feature Request" at https://issues.redhat.com/projects/LOG/issues/LOG-6?

It seems like a reasonable request, but please expand on the use-cases that prompted this request.

I'll close this ticket so we can continue discussion on JIRA without confusion.

commented

@jcantrill I can't close this ticket, can you close it?

commented

@alanconway I can't create any issues in openshift logging jira project. I only can create issues in some other projects.

image

commented

any updates on this? should I create a proposal PR for this in openshift/enhancement?

commented

I created https://issues.redhat.com/browse/LOG-1650 can you add some details to that?
Proposal is a good idea, esp. if you are not able to edit or comment on the JIRA.

commented

@alanconway thanks. I'm not able to edit the description, although I can add comments on that, so I'll create a proposal PR and will share the link here.

commented

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale