ci-operator does not support pulling multiple git repos

Question

ci-operator does not support pulling multiple git repos

0xmichalis opened this issue 6 years ago · comments

We want to create a job that tests Azure VM image builds. We have a playbook for building images in openshift-ansible.

The test flow is as follows:

run image node build playbook (openshift-ansible)
test built image is valid by using it to run a cluster (openshift-azure)
tag image and release

This job needs to pull openshift-ansible to do the node build in 1. (either via git for PRs and merges, or the published container image for periodic runs) AND openshift-azure for running the test deployment in 2.. We don't care about the commit pulled in 2.. At the moment, there is no support in ci-operator to make use of extra_refs which is not exposed via the downward API in prow. We are going to workaround this by putting openshift-azure in an image and use that directly in the template.

cc @openshift/sig-azure @stevekuznetsov @droslean @smarterclayton @bbguimaraes @petr-muller

Nikolaos Moraitis commented 5 years ago

/close

Steve Kuznetsov · Answer 1 · Fri Sep 14 2018 22:30:50 GMT+0800 (China Standard Time)

extra_refs which is not exposed via the downward API in prow.

It totally is exposed in the downward API, that is how clonerefsconsumes it upstream.

If you are testing openshift-ansible pull requests, why can't you write a template that uses the openshift-azure container images that are tagged into the release to do the install and verification?

Michalis Kargakis · Answer 2 · Fri Sep 14 2018 23:47:34 GMT+0800 (China Standard Time)

It totally is exposed in the downward API, that is how clonerefsconsumes it upstream.

It works if I use clonerefs but not if I do skip_cloning=true and use the ci-operator for cloning. Will the ci-operator work if I do the cloning in prow (skip_cloning=false)?

If you are testing openshift-ansible pull requests, why can't you write a template that uses the openshift-azure container images that are tagged into the release to do the install and verification?

Note that today we start with a periodic and eventually we will also test o-a PRs. openshift-azure is not part of the origin release.

Steve Kuznetsov · Answer 3 · Sat Sep 15 2018 01:32:51 GMT+0800 (China Standard Time)

It works if I use clonerefs but not if I do skip_cloning=true and use the ci-operator for cloning. Will the ci-operator work if I do the cloning in prow (skip_cloning=false)?

No, but has nothing to do with downwardapi.

Note that today we start with a periodic and eventually we will also test o-a PRs. openshift-azure is not part of the origin release.

We can hash out more next week in the meeting but you're choosing not to follow the established workflows with ci-operator so I am not surprised it's difficult to make it work

Michalis Kargakis · Answer 4 · Sat Sep 15 2018 01:40:23 GMT+0800 (China Standard Time)

External refs are set in JOB_SPEC only in case you do the cloning in prow so if you ever want to use them in ci-operator you'd have to fix prow first.

…

On Fri, Sep 14, 2018, 19:32 Steve Kuznetsov ***@***.***> wrote: It works if I use clonerefs but not if I do skip_cloning=true and use the ci-operator for cloning. Will the ci-operator work if I do the cloning in prow (skip_cloning=false)? No, but has nothing to do with downwardapi. Note that today we start with a periodic and eventually we will also test o-a PRs. openshift-azure is not part of the origin release. We can hash out more next week in the meeting but you're choosing not to follow the established workflows with ci-operator so I am not surprised it's difficult to make it work — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#142 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADuFfzAK9J02iJgom-7DjVTWhl74lFJHks5ua-hEgaJpZM4WpIz1> .

Nikolaos Moraitis · Answer 5 · Thu Feb 14 2019 20:13:14 GMT+0800 (China Standard Time)

duplicated with #258

OpenShift CI Robot · Answer 6 · Thu Feb 14 2019 20:13:34 GMT+0800 (China Standard Time)

@droslean: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.