Avoid duplicating common logic in Openshift templates

[Michalis Kargakis]

We need a way to reuse a single Openshift template which provides us a fresh cluster installed on Azure. We want to be able to execute actions before and after the cluster is installed. Examples for running before include building a node image that the install can use. Examples for running logic after include running all sorts of e2e tests or upgrades.

Strawman implementation: ci-operator reads a golang template and based on parameters provided into its env, it generates the actual Openshift template to use. Templates all the way down.

Another alternative was brought up by @stevekuznetsov in one of the latter ci meetings. IIUC, he alluded to adding cluster provisioning logic in the ci-operator so we could avoid using templates.

Thoughts?

@bbguimaraes @droslean @petr-muller @smarterclayton @stevekuznetsov

@openshift/sig-azure fyi

[Clayton Coleman]

We are probably going to embed the logic of the templates into ci-operator, but we’re not there quite yet. Continue using the templates for now while we try out the specific tasks. On Sep 7, 2018, at 5:38 AM, Michalis Kargakis <[e-mail]> wrote: We need a way to reuse a single Openshift template which provides us a fresh cluster installed on Azure. We want to be able to execute actions before and after the cluster is installed. Examples for running before include building a node image that the install can use. Examples for running logic after include running all sorts of e2e tests or upgrades. Strawman implementation: ci-operator reads a golang template and based on parameters provided into its env, it generates the actual Openshift template to use. Templates all the way down. Another alternative was brought up by @stevekuznetsov <https://github.com/stevekuznetsov> in one of the latter ci meetings. IIUC, he alluded to adding cluster provisioning logic in the ci-operator so we could avoid using templates. Thoughts? @bbguimaraes <https://github.com/bbguimaraes> @droslean <https://github.com/droslean> @petr-muller <https://github.com/petr-muller> @smarterclayton <https://github.com/smarterclayton> @stevekuznetsov <https://github.com/stevekuznetsov> @openshift/sig-azure <https://github.com/orgs/openshift/teams/sig-azure> fyi — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#133>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p43SQ1fXFlz1ike0459CDYRgrPwHks5uYj54gaJpZM4WegaN> .

[Steve Kuznetsov]

/close

[OpenShift CI Robot]

@stevekuznetsov: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.