Expand getCoordinates of newClass to access arguments

[timo-abele]

What problem are you trying to solve?

I would like to switch one constructor call for an other with JavaTemplate. E.g. if a class A offers two constructors A(int foo), A(int foo, double ba) I would like to be able to insert a new argument after, or replace the list of arguments altogether.

Describe the solution you'd like

API offers suitable methods through getCoordinates.

Have you considered any alternatives or workarounds?

Replacing the entire constructor call should work in theory.
withArguments() works as well, but JavaTemplates seem to be the way to go.

Additional context

Currently a constructor call can be replaced entirely, but it would be nice to be able to operate it without putting "new A" into the template, which requires me to find out the class name at runtime.
J.MethodInvocation already has getCoordinates().replaceArguments(), that could just be implemented in newClass as well.

Are you interested in contributing this feature to OpenRewrite?

probably won't find the time

[Tim te Beek]

Thanks for the suggestion @timo-abele ; I imagine this to be very similar to how we handle J.MethodInvocation, which I think should make for a nice addition.

rewrite/rewrite-java/src/main/java/org/openrewrite/java/tree/CoordinateBuilder.java

Lines 232 to 247 in 9bcac5a

     public static class MethodInvocation extends Statement { 
         MethodInvocation(J.MethodInvocation tree) { 
             super(tree); 
         } 
  
         public JavaCoordinates replaceArguments() { 
             return replace(Space.Location.METHOD_INVOCATION_ARGUMENTS); 
         } 
  
         /** 
          * Indicates replacement of the invocation's name and argument list, while preserving its select. 
          */ 
         public JavaCoordinates replaceMethod() { 
             return replace(Space.Location.METHOD_INVOCATION_NAME); 
         } 
     } 

Which would then need to be returned instead of CoordinateBuilder.Statement in

rewrite/rewrite-java/src/main/java/org/openrewrite/java/tree/J.java

Lines 4454 to 4456 in 516c70b

 public CoordinateBuilder.Statement getCoordinates() { 
     return new CoordinateBuilder.Statement(this); 
 }