openmultiplayer / open.mp

Open Multiplayer, a multiplayer mod fully backwards compatible with SA-MP

Home Page:https://open.mp

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

OnPlayerSelectedMenuRow, add checks for impossible row values?

BeckzyBoi opened this issue · comments

Describe the bug
There was an instance reported in my crash log where row from OnPlayerSelectedMenuRow was 157, when maximum number of rows is actually 12 (ranging from 0-11?).

To Reproduce
Steps to reproduce the behavior:
I'm unable to reproduce this, maybe the cause was a fake rpc packet sent by a player?

Expected behavior
row should never be anything less than 0 or more than 11.

Commit hash in master
Put the commit hash or link to the Github Action of the broken build here.
https://github.com/openmultiplayer/open.mp/actions/runs/8556095715

As far as i'm aware it can happen on released version too, but i am using latest nightly (link above).