openkruise / kruise

Automated management of large-scale applications on Kubernetes (incubating project under CNCF)

Home Page:https://openkruise.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] make docker-multiarch failed with vendor errors

ABNER-1 opened this issue · comments

What happened:

What you expected to happen:
make docker-multiarch in master, failed
error:

0.208 
0.208   To ignore the vendor directory, use -mod=readonly or -mod=mod.
0.208   To sync the vendor directory, run:
0.208           go mod vendor
------

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

We should fix Dockerfile_multiarch errors about vendor.

Environment:

  • Kruise version: master
  • Kubernetes version (use kubectl version):
  • Install details (e.g. helm install args):
  • Others:

add label kind/good-first-issue

/assign @ls-2018

This is a small problem, I hope there are enthusiastic students to complete.
@ABNER-1 Would you like to finish it?

RUN GOOS=${TARGETOS} GOARCH=${TARGETARCH} CGO_ENABLED=0 GO111MODULE=on go build -mod=vendor -a -o manager main.go \
&& GOOS=${TARGETOS} GOARCH=${TARGETARCH} CGO_ENABLED=0 GO111MODULE=on go build -mod=vendor -a -o daemon ./cmd/daemon/main.go

These two lines also need to be changed.

commented

/unassign ls-2018
/assign MichaelRren

@liangyuanpeng: GitHub didn't allow me to assign the following users: MichaelRren.

Note that only openkruise members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/unassign ls-2018
/assign MichaelRren

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

commented

/assign @MichaelRren

@liangyuanpeng: GitHub didn't allow me to assign the following users: MichaelRren.

Note that only openkruise members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @MichaelRren

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.