openjournals / joss-reviews

Reviews for the Journal of Open Source Software

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[PRE REVIEW]: LiGuard: A GUI-powered Python Framework for Processing Point-Cloud Data

editorialbot opened this issue Β· comments

Submitting author: @m-shahbaz-kharal (Muhammad Shahbaz )
Repository: https://github.com/m-shahbaz-kharal/LiGuard-JOSS
Branch with paper.md (empty if default branch): main
Version: v1.0.0
Editor: @hugoledoux
Reviewers: @chenzhaiyu, @tgoelles
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f57d8cdafbb47f64891ce84685b4cd05"><img src="https://joss.theoj.org/papers/f57d8cdafbb47f64891ce84685b4cd05/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f57d8cdafbb47f64891ce84685b4cd05/status.svg)](https://joss.theoj.org/papers/f57d8cdafbb47f64891ce84685b4cd05)

Author instructions

Thanks for submitting your paper to JOSS @m-shahbaz-kharal. Currently, there isn't a JOSS editor assigned to your paper.

@m-shahbaz-kharal if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.03471 is OK
- 10.21105/joss.00990 is OK
- 10.1109/MCSE.2007.55 is OK

MISSING DOIs

- 10.1109/icra.2011.5980567 may be a valid DOI for title: 3D is here: Point Cloud Library (PCL)
- No DOI given, and none found for title: Open3D: A Modern Library for 3D Data Processing
- No DOI given, and none found for title: Laspy
- No DOI given, and none found for title: pyntcloud
- No DOI given, and none found for title: The OpenCV Library
- 10.1177/0278364913491297 may be a valid DOI for title: Vision meets robotics: The kitti dataset
- No DOI given, and none found for title: OpenPCDet: An Open-source Toolbox for 3D Object De...
- No DOI given, and none found for title: MMDetection3D: OpenMMLab next-generation platform ...

INVALID DOIs

- None

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1577.7 files/s, 132617.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          44            766           1278           1992
reStructuredText                11            162            139            514
Markdown                         5             61              0            365
YAML                             4             25              5            167
TeX                              1             10              0             93
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            67           1036           1430           3166
-------------------------------------------------------------------------------

Commit count by author:

     1	m-shahbaz-kharal

Paper file info:

πŸ“„ Wordcount for paper.md is 806

βœ… The paper includes a Statement of need section

License info:

βœ… License found: MIT License (Valid open source OSI approved license)

πŸ‘‹ @m-shahbaz-kharal - Thank you for your submission to JOSS! You mentioned that the software version that is being submitted to JOSS is a stripped-down version. Could you confirm that this software in any other form has not been previously published? Also, is the software being presented a fully working version of the codebase, just minus any proprietary features? And lastly, I am assuming permission has been granted to open-source this code from the original codebase per the license presented in the paper?

Thanks so much for any clarification you can provide!

@crvernon, thank you for the comment.

  • Yes, I confirm that the software in any other form has not been previously published.
  • Yes, the software is still fully working; it is designed to allow adding/removing custom algorithms, so we just removed our proprietary ones.
  • Yes, all code that is present in the submission is granted an open-source permission. In our private full-version repository, the license is subject to change only for the code that is proprietary to us and not for the code present in the submitted repository.

Thanks for the clarification @m-shahbaz-kharal!

@m-shahbaz-kharal - We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

Assigned! @hugoledoux is now the editor

@chenzhaiyu added to the reviewers list!

@tgoelles added to the reviewers list!

@editorialbot start review

OK, I've started the review over in #6751.