meta theme-static-root is also used in admin
freesoul opened this issue · comments
This meta tag should be present in the template.html of the admin, or template.html should be also overrided by the one by the template in the admin.
The reason is that this variable is used for assets in widgets from the theme (example reuse.png in reuses widget from french theme)
Thank you for this ticket and the one in udata-front. I suggest that we continue the discussion here since both are similar.
I see two things here.
First, we don't have any more placeholder widgets in udata (reuse.png, organization.png, etc.), thus having an issue with this widget with udata in standalone in any case.
Secondly, metadata.html is not overridden by theme (gouvfr for example) in admin. But I wonder if we should actually override it, since the admin is out of scope from udata-front. In any case, we probably have too much duplicate code between both metadata.html leading to confusion and wonder if we could use a hook logic for additional metadata in front for example instead. Would be interested in your opinions @abulte, @quaxsze.
Seeing that the second point won't probably be fixed very soon and we would like a udata standalone to work nicely in any case , I would suggest to replace theme_static code in udata by static_root, adding missing assets in udata core. We wouldn't be able to override these with a theme though. Would that be a working solution for you @freesoul?