Wrong interaction between stdout flag of different loggers

[Nil Geisweiller]

Problem

Setting the stdout flag of a logger consequently, and incorrectly, sets the stdout flags of other loggers to that same value.

Reproducibility

Enable LoggerUTest::xtestLoggerStdoutFlagInteraction (i.e. remove x)

cogutil/tests/util/LoggerUTest.cxxtest

Lines 287 to 298 in 64bbb63

 void xtestLoggerStdoutFlagInteraction() 
 { 
     Logger my_logger; 
  
     // Set different stdout flags for my_logger and the default logger 
     logger().set_print_to_stdout_flag(false); 
     my_logger.set_print_to_stdout_flag(true); 
  
     // Make sure their flags differ 
     TS_ASSERT_DIFFERS(logger().get_print_to_stdout_flag(), 
                       my_logger.get_print_to_stdout_flag()); 
 } 

[Nil Geisweiller]

I suspect the problem was introduced while fixing #118

[Nil Geisweiller]

@linas if you happen to have a fix, great, otherwise no worries I'll take care of it.

[Linas Vepštas]

Hmm. I guess you have it set up so that different loggers write to the same log file? Yeah, that flag seems to be operating at a per-file basis.