opencivicdata / scrapers-ca

Canadian legislative scrapers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

confused about ca_ab issue

cmyr opened this issue · comments

ca_ab isn't currently working, because there's a new party, the 'United Conservatives'. Adding this to the PARTIES lookup table gets the scraper working again, but then the pupa update fails with

pupa.exceptions.UnresolvedIdError: cannot resolve pseudo id to Organization: ~{"classification": "party", "name": "United Conservative"}.

I feel like I've been confused about something similar to this in the past. @jpmckinney What (loosely) is going on here? we're checking the generated json against some canonical datasource? do we generate this?

(I'm now very confident I've asked a very similar question before. I'll do some digging and see if I can find that)

edit: (for posterity there's some useful information in opencivicdata/ocd-division-ids#147, but it doesn't address this particular question)

edit 2: there's a similar issue in my recent halifax fix: pupa.exceptions.UnresolvedIdError: cannot resolve pseudo id to Post: ~{"label": "District 16 Bedford\u2014Wentworth", "role": "Councillor", "organization__classification": "legislature"}. So I'm clearly doing something wrong.

I think you just need to add an entry for the party to https://github.com/opencivicdata/scrapers-ca/blob/master/ca_ab/__init__.py

@jpmckinney ah okay I hadn't noticed that init_.py was populated. 👍