add_contact method in utils.py is broken

Question

add_contact method in utils.py is broken

patcon opened this issue 8 years ago · comments

I think it broke when we started lower-casing in header_converter:
https://github.com/opencivicdata/scrapers-ca/blob/master/utils.py#L218

And now the contact detail type map returns nothing, at least for toronto, for which the key being looked up is "email":
https://github.com/opencivicdata/scrapers-ca/blob/master/utils.py#L24-L50

Not having experience with other cities, how might you suggest resolving this? Is the CONTACT_DETAIL_X_MAP part still used in other cities?

Patrick Connolly · Answer 1 · Mon Apr 11 2016 02:01:51 GMT+0800 (China Standard Time)

Ugh. Nevermind. Toronto isn't getting contact data put into the tables, but I now realize it's not related to above. I'll keep investigating, but nevermind for now

Patrick Connolly · Answer 2 · Mon Apr 11 2016 02:15:30 GMT+0800 (China Standard Time)

OK, so is it that a membership is the only thing that gets contact details?

James McKinney · Answer 3 · Mon Apr 11 2016 02:18:07 GMT+0800 (China Standard Time)

Generally, contact details relate to a person's membership. If you were to add contact details to a person directly, then semantically that would be to contact them outside the context of their employment, which I don't this is a relevant use case.

Patrick Connolly · Answer 4 · Mon Apr 11 2016 02:23:22 GMT+0800 (China Standard Time)

ok, while this will require more complicated logic in any system building on OCD data, it does strike me as being more sensible :) Drats to the complexity of the real world!