opencart / opencart

A free shopping cart system. OpenCart is an open source PHP-based online e-commerce solution.

Home Page:https://www.opencart.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[master] Admin - Product Filter - by Price is not working

pemaier opened this issue · comments

What version of OpenCart are you reporting this for?
master
Describe the bug
A clear and concise description of what the bug is
What section does it affect?
Open the admin product page and filter products bey price e.g. 80.00
Result is empty.
Also the result calculation is not working.

To Reproduce
Steps to reproduce the behavior:
see description of the bug

Expected behavior
A clear and concise description of what you expected to happen.
correct results

Screenshots / Screen recordings
If applicable, add screenshots or recordings to help explain your problem. Please keep these short and if you can, edit them to point out when/where the problem is.
https://www.useloom.com/ is perfect for screen recording with Chrome or with their desktop app

e.g. result for filter price = 0
image

Server / Test environment (please complete the following information):

  • Local development? Deployed to a web server? server
  • Operating system cloudlinux
  • PHP version 8.2
  • Apache version 2.4
  • Browser(s) tested with [e.g. chrome, safari - if applicable] FF
  • Version [e.g. 22] 115.0

if (!empty($data['filter_price'])) {

if (!empty($data['filter_price'])) {

if (isset($data['filter_price'])) {

sorry not working

See

if (isset($data['filter_price']) && $data['filter_price'] !== '') {

... I tested it and it doesn't work. What you show me I already saw but in line 880 it's not working because of the logic.

Like '0' - not working
Like '0.0000' - not working
(float) 0 - 0
(float) 90.0000 = 90

$sql .= " AND `p`.`price` LIKE '" . (float)$data['filter_price'] . "'";

$sql .= " AND p.price LIKE '" . $this->db->escape($data['filter_price']) . "'";