Connections aren't being closed

Question

Connections aren't being closed

dougli opened this issue a year ago · comments

The library uses requests to fetch data from OpenAI servers, but we never call .close() on those connections which leaves dangling open file handles on the OS.

Can we clean these connections up gracefully, either after a period of time, or after making a request? There is an advantage to leaving it open as it doesn't have to do the HTTPS handshake on every request, but we should clean this up properly after a period of idleness.

This bug interacts very poorly with another bug in Docker Desktop -- moby/vpnkit#587; the openai library stops working entirely after running it in a Docker container on Mac / Windows for a few minutes. All requests to OpenAI servers time out indefinitely.

hallacy · Answer 1 · Fri Dec 02 2022 19:15:04 GMT+0800 (China Standard Time)

Hi @dougli!

Thanks for writing in. I'll surface this to the team and get it on our roadmap. That said, we happily accept PRs if you'd like to take a shot at fixing this.

Arnaud Loonstra · Answer 2 · Wed Mar 22 2023 23:45:44 GMT+0800 (China Standard Time)

Any pointers where the sockets are opened or where they should be closed? I'm running into this issue

Arnaud Loonstra · Answer 3 · Wed Mar 22 2023 23:49:45 GMT+0800 (China Standard Time)

In my case it helps to ignore the ResourceWarning by adding:

import warnings

warnings.simplefilter("ignore", ResourceWarning)

Doesn't fix the open filedescriptors, though

bauefikapa · Answer 4 · Fri May 12 2023 00:58:18 GMT+0800 (China Standard Time)

We have deployed a dockerized application in production which crashes periodically because of this. Over time more and more connections are being opened until the container crashes because of a memory error.