openSUSE / obs-sign

sign daemon and client for remote gpg signing.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

sign.c:741: bad call to memset ?

dcb314 opened this issue · comments

sign.c:741:26: warning: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]

memset(ctx, 0, sizeof(ctx));        /* In case it's sensitive */

Maybe better code

memset(ctx, 0, sizeof(*ctx));        /* In case it's sensitive */

But... but... that's not even my code. It's from the public domain md5 implementation.
Anyway, fixed. Thanks for spoting that.