open5e / open5e

An SRD and open-source material reference site for 5th edition D&D

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Search endpoint should be scoped to selected sources

eepMoody opened this issue · comments

Want to explore a half-measure on this.

User feedback is that they expect this to honor their source selections. But If we hide it something silently because of a source selection it might be assumed it wasn't there.

I believe the correct resolution here is a hybrid solution, where we execute the search query against the entire dataset.
Then on the UI layer, we can hide the non-matching results behind a "view additional results from other sources" kind of button?

image image

I am taking a look at this today. Going to take some extra time to give the /search page a little refactor while I am here, it needs one!