Giters

open-telemetry / opentelemetry-helm-charts

OpenTelemetry Helm Charts

Home Page:https://opentelemetry.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Not possible to create ServiceMonitor if running in DaemonSet mode

tiithansen opened this issue · comments

commented

It should be possible to monitor collectors if they run in DaemonSet mode.

opentelemetry-helm-charts/charts/opentelemetry-collector/templates/servicemonitor.yaml

Line 1 in ad61364

{{- if and .Values.serviceMonitor.enabled .Values.serviceMonitor.metricsEndpoints (or (eq .Values.mode "deployment") (eq .Values.mode "statefulset")) }}
condition won't allow to create ServiceMonitor if in DaemonSet mode.

commented

This is a hold-over from when we didn't allow the daemonset mode to create a service. Now that we allow daemonset to have a service, we should allow the service monitor as well.