if l->len == 16G,mem_clear_njobs will be added twice
wongkq opened this issue · comments
Line 1317 in 80e2b1d
if l->len == 16G, mem_clear_njobs will be added twice,but when assigned for job_args[i], it is only assigned once。Is this a bug?
I haven't verified to be sure, but from examining the code I think it may be a bug. It should probably be something like
mem_clear_njobs += (r->len - 1) / MEM_REGION_CLEAR_JOB_SIZE;
I don't think this causes any functional problem, it just means we allocate more than is needed here:
Lines 1320 to 1321 in 80e2b1d
thanks