[FEATURE] implement standard error classes

Question

[FEATURE] implement standard error classes

toddbaert opened this issue a year ago · comments

Requirements

We already have error codes defined, but it would be nice to define error classes to make things a bit more ergonomic for contributors. Basically something like is already implemented in this contrib ; simple classes wrapping these error types that can easily be thrown.

Valentinas Kaminskas · Answer 1 · Sun Feb 05 2023 03:53:52 GMT+0800 (China Standard Time)

Hello, I would create classes for each type (+ base class). If this is expected, I can create PR with changes. :)

Todd Baert · Answer 2 · Mon Feb 06 2023 22:25:22 GMT+0800 (China Standard Time)

@valentk777 , yep, that's what I had in mind. The link above to a contrib/provider which implements it's own is a good outline (they could be deleted from that provider and the provider could use the errors you add to the SDK).

I will assign you the issue.

Valentinas Kaminskas · Answer 3 · Tue Feb 07 2023 15:29:32 GMT+0800 (China Standard Time)

PR is ready for review. Sorry for this chain of closed PR's. It was naming issues and signature issues. I fixed all of them and now PR ready for reviews :)