open-amt-cloud-toolkit / mps

The Management Presence Server (MPS) is a cloud-agnostic microservice that enables platforms featuring Intel® AMT to be managed over the internet.

Home Page:https://open-amt-cloud-toolkit.github.io/docs/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Secret Interface needs to provide generalized responses based on response from secret store

matt-primrose opened this issue · comments

Describe the bug 🪲
Currently the secret interface blindly returns either data retrieved from the secret store or null if error. If the secret store provided a more robust return code, MPS could better handle issues where the secret store is unavailable for different reasons (sealed, service not available, data doesn't exist).

Currently MPS can take fairly drastic action based on getting a null response from the secret store when checking if the MPS certificates exist. If it receives null, MPS will regenerate certificates, causing all currently configured AMT devices to have invalid certificates. Have a more detailed return code can help MPS to moderate this action.