Giters

onnx / models

A collection of pre-trained, state-of-the-art models in the ONNX format

Home Page:http://onnx.ai/models/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

arcface readme about similarity transformation and affine transformation

muqishan opened this issue · comments

commented

Dear ONNX Team,

While studying and utilizing your implementation of the ArcFace model, I have noticed an inconsistency between the description in the README file and the code implementation. Specifically, the README mentions that the alignment of images in the preprocessing step is done via an "affine transform"​1​. However, in the face_preprocess.py file, a "similarity transform" is actually used​2​.

While a similarity transform is a specific type of affine transform, there are important differences between them in terms of their mathematical properties and applications. In some cases, using a similarity transform as opposed to a general affine transform could yield different results. Therefore, I believe that describing this step accurately in the README would be beneficial for beginners.

I hope this issue can be addressed to aid more individuals in understanding and utilizing