online-go / gtp2ogs

GTP Wrapper to allow bots to interface with the Online-Go.com Server

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Latest crashes when accepting a game (possibly only if there is a per user concurrent game limit)

windo opened this issue · comments

Crashes with:

May 12 14:13:25 ! source-map-support.js:495 
May 12 14:13:25 ! source-map-support.js:496 /home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/src/main.ts:712
            const game_count = Object.keys(this.connected_games).filter((game_id) => {
                                                                 ^
May 12 14:13:25 ! source-map-support.js:499 TypeError: Cannot read properties of undefined (reading '222842')
    at /home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/src/main.ts:717:49
    at Array.filter (<anonymous>)
    at Main.checkGamesPerPlayer (/home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/src/main.ts:712:66)
    at Main.handleNotification (/home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/src/main.ts:294:30)
    at GobanSocket.<anonymous> (/home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/src/main.ts:150:58)
    at GobanSocket.emit (/home/siim/projects/gtp2ogs-release/node_modules/eventemitter3/index.js:181:35)
    at WebSocket.<anonymous> (/home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/node_modules/goban/src/GobanSocket.ts:266:22)
    at callListener (/home/siim/projects/gtp2ogs-release/node_modules/ws/lib/event-target.js:290:14)
    at WebSocket.onMessage (/home/siim/projects/gtp2ogs-release/node_modules/ws/lib/event-target.js:209:9)

Inspecting the Game.state reveals there is no player_pool property. I can send a change that fixed this for me locally.

After checking for state, I also got crashes like this:

May 12 16:44:07 ! source-map-support.js:495 
May 12 16:44:07 ! source-map-support.js:496 /home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/src/main.ts:712
            const game_count = Object.keys(this.connected_games).filter((game_id) => {
                                                                 ^
May 12 16:44:07 ! source-map-support.js:499 TypeError: Cannot read properties of null (reading 'player_pool')
    at /home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/src/main.ts:717:27
    at Array.filter (<anonymous>)
    at Main.checkGamesPerPlayer (/home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/src/main.ts:712:66)
    at Main.handleNotification (/home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/src/main.ts:294:30)
    at GobanSocket.<anonymous> (/home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/src/main.ts:150:58)
    at GobanSocket.emit (/home/siim/projects/gtp2ogs-release/node_modules/eventemitter3/index.js:181:35)
    at WebSocket.<anonymous> (/home/siim/projects/gtp2ogs-release/dist/webpack:/gtp2ogs/node_modules/goban/src/GobanSocket.ts:266:22)
    at callListener (/home/siim/projects/gtp2ogs-release/node_modules/ws/lib/event-target.js:290:14)
    at WebSocket.onMessage (/home/siim/projects/gtp2ogs-release/node_modules/ws/lib/event-target.js:209:9)
    at WebSocket.emit (node:events:517:28)

So state is not always present and it seems player_pool is never present. I had tested on beta first before switching to the updated version, so I guess player_pool might be present on beta.

Anyway #420 fixes the crashes for me at least.