onicagroup / runway

Simplify infrastructure/app testing/deployment

Home Page:https://runway.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Pylint returning incorrect results in Github Actions

jake-skipper opened this issue · comments

Bug Description

pylint runs are returning the following in the Github Actions pipeline runs:

Running pylint...

------------------------------------
Your code has been rated at 10.00/10

However, running the same tests (following the pipeline steps closely to ensure similar behavior) returns many linting errors (that are legitimate). I don't know if some type of caching is happening at the runner level to cause an incorrect Pylint result, but we need to fix the pipeline and be careful to lint locally before submitting internal PRs.

Expected Behavior

Pylint should give accurate results when running from the pipeline.

Steps To Reproduce

Example project: ...

  1. From a local dev environment run make setup
  2. run make lint.

Runway version

2.6.3

Installation Type

pypi (pip, pipenv, poetry, etc)

OS / Environment

Tested in Ubuntu 22.04 dev environment.

Anything else?

This was exposed at https://github.com/onicagroup/runway/actions/runs/3054789046/jobs/4927104209 , a pipeline run for pylint upgrade. It gives a few of the errors that you see locally, but not nearly the full list

This should be fixed in #1679

Resolved in #1679