Python3 is required

Question

Python3 is required

lthiery opened this issue 2 years ago · comments

Under python2, the following error occurs:

Extracting files to: ubifs-root
extract_files Error: 'module' object has no attribute 'commonpath'

AT0myks · Answer 1 · Sun Nov 27 2022 00:25:06 GMT+0800 (China Standard Time)

This seems to come from c6a1272. os.path.commonpath indeed requires Python 3.5+. Unless you really need v0.8.2 you can use v0.8.0 where this code wasn't present.

Louis Thiery · Answer 2 · Mon Nov 28 2022 02:29:22 GMT+0800 (China Standard Time)

It's not a big deal on my end. I just ran it in Python3.

Louis Thiery · Answer 3 · Mon Nov 28 2022 02:31:31 GMT+0800 (China Standard Time)

#62 opened to update docs

Jason Pruitt · Answer 4 · Mon Nov 28 2022 02:34:08 GMT+0800 (China Standard Time)

Hi lthiery,

Thank you for pointing this out. I will have to consider Python 2 support going forward, as it is EOL, and I imagine issues like this will only get worse going forward. I would imagine ubi_reader is probably used on newer OS's where python 3 is going to be supported, instead of older hardware.

-Jason

Louis Thiery · Answer 5 · Mon Nov 28 2022 02:36:59 GMT+0800 (China Standard Time)

I would agree with dropping Python2 support. Generally, this package seems useful in build and development systems which should have no problem upgrading to Python3.

Jason Pruitt · Answer 6 · Sun Dec 04 2022 12:39:34 GMT+0800 (China Standard Time)

I ended up getting sucked into a different issue, that only showed up when comparing extractions from Python 2 vs 3. I ended up fixing it so Python 2 works in the latest commit.

-Jason

Louis Thiery · Answer 7 · Sun Dec 04 2022 13:13:02 GMT+0800 (China Standard Time)

You're a kind person! Thanks