Giters

omriharel / deej

Set app volumes with real sliders! deej is an Arduino & Go project to let you build your own hardware mixer for Windows and Linux

Home Page:https://deej.rocks

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Max slider value is not adjustable

LovroG05 opened this issue · comments

commented

I run this on an esp32, and when i max the sliders, it returns 4095, which gets flagged as a dirty line. This means i can only use 1/4 of my slider.

Can you please add this to the config?
If you want, i can code it and PR

thanks

commented

I made a fix on the Arduino's side, if you want I can open a merge request.

commented

Ok, just found out that according to the CONTRIBUTING.md PRs will not be merged. Hope he will add this feature in the future. 😊

commented

Hi there @LovroG05, thanks for writing. There are no current plans to allow a configurable range of values for the serial interface - the expectation is that devices with a 12-bit ADC instead map the values to the 0-1023 range used in the default Arduino sketch. There is map() function in Arduino to allow you to easily do that.

Putting this as a config option will ultimately result in users attempting to tweak it to try and solve issues that originate in incorrect wiring, faulty pots, etc. - and thus will also make it more difficult to help them with troubleshooting.