omridevk / ng-keyboard-shortcuts

Dead Simple Keyboard Shortcuts Management for Angular

Home Page:https://ng-keyboard-shortcuts.vercel.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ng-keyboard-shortcuts disabled property is not recognized if bound to a false initialized property

domdeger opened this issue · comments

When you bind a false initialized property to disabled input then the setter runs before the shortcuts input is set (when e.g. calculated in ngOnInit). The disabled property is never checked again then so the shortcuts input is set afterwards and then just registers events.

My PR #95 should fix the issue.

Thanks for this awesome library btw, it helped me and my team a lot! :)

commented

fixed in version 10.1.17

commented

Thanks @domdeger !!!