omridevk / ng-keyboard-shortcuts

Dead Simple Keyboard Shortcuts Management for Angular

Home Page:https://ng-keyboard-shortcuts.vercel.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Compilation problem: ng-keyboard-shortcuts.plugin is missing

ssj4maiko opened this issue · comments

I recently added your library to my project, and I got the following error during compilation.

Error: node_modules/ng-keyboard-shortcuts/index.d.ts:5:49 - error TS2307: Cannot find module './lib/ng-keyboard-shortcuts.plugin' or its corresponding type declarations.

5 export { KeyboardShortcutsPluginProvider } from "./lib/ng-keyboard-shortcuts.plugin";

Version 3.0.6

Commenting the line makes it work, but of course, it should cause problems for new users, besides, I'm guessing there must be some special functionality that may be missed with that, but well, there is still a problem nonetheless.

I'm using Angular 13, and again, just commenting that makes it work, so it's not hard for me to fix for myself, so no haste I guess. Of course, no problems in functionality and it works wonderfully.

Edit:
There is also this error

ERROR TypeError: can't access property "currentValue", changes.closeKey is undefined
    ngOnChanges ng-keyboard-shortcuts.mjs:1338

The file is this: ng-keyboard-shortcuts/fesm2020/ng-keyboard-shortcuts.mjs

Adding this just before course also fixes the problem:
if (!changes["closeKey"]) { return; }

Just updated this lib to latest version with angular 14. Same problem.

Same problem here with version 13.0.6 and angular 13

Getting it all versions after 13.0.5

commented

I'll look into it, sorry for the delay.

commented

Can you please provide a link to reproduce? I cannot reproduce it in my local playground env nor in codesandbox.
Thanks.

commented

Should be fixed now in 13.0.7 please let me know if the issue persist.

commented

Is it solved?

13.0.7 solved it for me using angular 13

commented

Closing, let me know if the issue persist, I will look again.