omridevk / ng-keyboard-shortcuts

When used with rxjs version 7.3.0 (but presumably 7 and upwards) I get an error thrown with the message object unsubscribed. There's nothing in the stack trace to indicate that ng-keyboard-shortcuts is the culprit, but I've discovered through trial and error that removing the <ng-keyboard-shortcuts> component from my page's HTML template makes the issue go away. I've further established that it is the shortcuts attribute which causes it, regardless of the inputs to that attribute. I know this because <ng-keyboard-shortcuts [shortcuts]="[]"></ng-keyboard-shortcuts> causes the error, but <ng-keyboard-shortcuts></ng-keyboard-shortcuts> does not.

I can also confirm that identical code on an identical version of ng-keyboard-shortcuts does not cause this error with rxjs 6.7.0 installed, so the issue is compatibility with rxjs 7 I think, which does have some breaking changes in it.

Steps to reproduce the behavior:
Embed <ng-keyboard-shortcuts [shortcuts]="[]"></ng-keyboard-shortcuts> in a page within an Angular 12 app with rxjs 7.3.0 installed

Hi @omridevk, It seems the issue is being caused due to use of tap operator

ng-keyboard-shortcuts/projects/ng-keyboard-shortcuts/src/lib/ng-keyboard-shortcuts.service.ts

Lines 199 to 212 in 11af887

    
           private keydownSequence$ = this.shortcuts$.pipe( 
        
               map(shortcuts => shortcuts.filter(shortcut => shortcut.isSequence)), 
        
               switchMap(sequences => 
        
                   this.keydown$.pipe( 
        
                       map(event => { 
        
                           return { 
        
                               event, 
        
                               sequences 
        
                           }; 
        
                       }), 
        
                       tap(this.timer$) 
        
                   ) 
        
               ), 
        
               scan(

and, there have been changes to tap operator in rxjs causing the issue. Passing the function instead of subject directly should fix the issue.

Can you please confirm the fix, accordingly I will raise a PR if needed. Thanks :)

Hello is this going to be fixed by an updated version?

and, there have been changes to tap operator in rxjs causing the issue. Passing the function instead of subject directly should fix the issue.

Can you please confirm the fix, accordingly I will raise a PR if needed. Thanks :)

Like so?

        switchMap(sequences =>
            this.keydown$.pipe(
                map(event => {
                    return {
                        event,
                        sequences
                    };
                }),
                tap(val => this.timer$.next(val))
            )
        ),

I'm not knee deep into rxjs. I do know tap() and I do know that timer$ is a Subject, but what I don't know is what tap(this.timer$) does. Does it proxy the Observable's next()/error()/complete() functions to the timer$ Subject?
I always used tap with a callback function like so tap(val => console.log(val))

It basically calls next with the value, but I think it was removed in version 7.

Fixed in version 13.

	private keydownSequence$ = this.shortcuts$.pipe(
	map(shortcuts => shortcuts.filter(shortcut => shortcut.isSequence)),
	switchMap(sequences =>
	this.keydown$.pipe(
	map(event => {
	return {
	event,
	sequences
	};
	}),
	tap(this.timer$)
	)
	),
	scan(

object unsubscribed error when used with RxJS 7