Should shouldComponentUpdate use valueOf to deref so doesn't have to check if it is a cursor?

Question

Should shouldComponentUpdate use valueOf to deref so doesn't have to check if it is a cursor?

jeffbski opened this issue 10 years ago · comments

In the facebook/immutable-js issues we were asking to get a Cursor.isCursor function which could be used rather than checking for deref existence.

Lee Byron suggested that maybe it would be better to use valueOf to deref for comparisons since if it is already not a cursor it returns itself.

See: immutable-js/immutable-js#300 (comment)

Alberto Leal · Answer 1 · Tue Mar 03 2015 05:24:56 GMT+0800 (China Standard Time)

Yes! I hadn't considered the .valueOf() function.

There's is a PR to simplify shouldComponentUpdate : #78

And we can simplify it even further.

Mikael Brevik · Answer 2 · Tue Mar 03 2015 05:33:22 GMT+0800 (China Standard Time)

Yeah, haven't thought of this. Good move! However, this might break the choice to use different immutable/cursor libraries with Omniscient. As not doing isCursor and unCursor would imply that a different cursor lib would have to implement .valueOf as well.

Mikael Brevik · Answer 3 · Sat Sep 19 2015 06:05:55 GMT+0800 (China Standard Time)

Found that this wouldn't change anything, and not make the code simpler. Closing this. Thanks for all feedback!