omni-network / omni

Monorepo for Omni node, contracts and other related tools

Home Page:https://omni.network

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

feat(xprovider): fetch by blockhash, not height

ttarsi opened this issue · comments

We should query for msgs and receipts by blockhash, not height. This gives us a bit more confidence in what we query and is more reorg-resistant.

@corverroos I've hit a bit of a blocker here. Although geth's FilterQuery allows one to specify a BlockHash, this is abstracted away behind the BoundContract type, which only allows queries based on height (through the FilterOpts type).

We're a little restricted by the geth interfaces here. I don't have an easy way to do this without some major refactor or forking geth, neither of which we likely want to do.

I wonder whether you have any ideas here?

^Discussed offline, Corver pointed out that I could just use the RPC client