Can't add sites to blacklist

Question

Can't add sites to blacklist

mrjovanovic opened this issue 7 years ago · comments

Installed addon, type foobar.com into "Add to blacklist..." field and clicked "Add"

Expected behavior:
Site is added to the blacklist

Actual behavior:
Nothing happens

Using Firefox ESR 52.4.0 on Debian 9. Would be happy to provide info/logs as necessary. Other installed addons: uBlockOrigin and VimFX.

William Pietri · Answer 1 · Fri Oct 13 2017 11:06:24 GMT+0800 (China Standard Time)

I can confirm this behavior on Firefox 57 with Ubuntu 16.04.3. It only happened for me upon initial install. After I restarted the browser, I could properly add sites.

Jason Tan · Answer 2 · Fri Oct 13 2017 18:10:23 GMT+0800 (China Standard Time)

That’s certainly strange. I’ll check on it hopefully this weekend, see if I can figure out VMs. I have noticed that lots of things seem a bit wonky on Linux.

Jason Tan · Answer 3 · Mon Oct 16 2017 10:35:52 GMT+0800 (China Standard Time)

Okay, so the problem is that Debian, by default, disables the storage.sync. I don't think there's anything on my side that I can force it to switch. Maybe like wpietri it'll do it on its own... otherwise you'll have to manually switch it on.

So go to about:config, search "storage.sync", and enable it.
@mrjovanovic

By the by, testing it in VirtualBox, do you get NaN in the popup when you click the monastery icon in the toolbar too?

Eviatar Bach · Answer 4 · Fri Nov 17 2017 09:17:17 GMT+0800 (China Standard Time)

I am getting this problem as well with Firefox 57 on Ubuntu 17.10. storage.sync is enabled, and restarting or refreshing Firefox doesn't help.

Jason Tan · Answer 5 · Fri Nov 17 2017 09:43:51 GMT+0800 (China Standard Time)

@eviatarbach
Could you open up the browser toolbox and filter for "background"? Ctrl-Alt-Shift-I to open it, or it's under Tools in the menu.
There's a few lines out of a file "background.js" - could you tell them to me? I don't think there's anything out of the ordinary there, but might as well.

Now, go to the preferences page and have it open, and then try to add a site to the blacklist. See if anything gets printed in the browser toolbox console. It should be under "sitelist.js" so you'll probably have to clear the "background" filter search.

Eviatar Bach · Answer 6 · Sat Nov 25 2017 05:56:46 GMT+0800 (China Standard Time)

Strangely enough, it suddenly started working and I can't reproduce the issue anymore. Thank you for the great work!

Jason Tan · Answer 7 · Sat Nov 25 2017 06:26:42 GMT+0800 (China Standard Time)

Oh well that's good. Thanks!
...man but those are the worst type of bugs...

Pascal Bourgault · Answer 8 · Thu Jan 18 2018 04:30:29 GMT+0800 (China Standard Time)

Had this bug on Firefox ESR 52.5.1 running on Centos Linux 7.
Restarting didn't do anything. But the issue was fixed by setting "webextensions.storage.sync.enabled" to True in about:config.

Miloš Jovanović · Answer 9 · Wed Jan 24 2018 05:00:38 GMT+0800 (China Standard Time)

@omivore
I am sorry to reply so late. The issue does not appear at all with storage.sync enabled. To answer your question - with it disabled, I get an empty string in the pop-up where the time should be.