"List of sites" page block with pagination
allanaaa opened this issue · comments
When pagination is turned on, the buttons appear odd and the block sometimes overflows its available width.
There should now be some corrective styles for list of sites pagination ready for a look.
No changes yet.
Hmm, can you do a hard refresh? I was able to see changes on your testing installation.
Yep, looks good in Foundation - Thanks Roy is still:
I forgot that Foundation had some custom markup for pagination, so I went back and corrected the page block styles to reference the actual default markup. Foundation has also been adjusted accordingly. I think everything's ready for another look.
It looks better in Thanks Roy, but maybe some spacing work is needed on the buttons:
Foundation looks good.
Default is also a bit wonky in buttons and spacing:
Center Row has different-sized buttons?
And Cozy looks pretty much the way Default does:
I've added some more default styles to the core to bridge some of the inconsistencies. Papers, The Daily, Center Row, and Cozy also have updates. The other themes should be looking okay with the updated core styles.
Any chance this has messed up the pagination buttons in the admin side?
Yup, though an easy fix is in and ready for a look.
Admin is fixed.
Thanks Roy could still use some refinement:
Default appears to have genuinely no text in the box. Not just a "1" in white or something.
Everything else seems okay at the moment.
Improved spacing on both, and default had what i think was a typo on text inputs giving them massive padding on the sides that clipped the actual content. Should be fixed and ready for review.
Default looks great now.
Thanks Roy is an improvement for sure - I'm not sure if you want the page box to be the same width as the thumbnails? But it's not quite there, and I don't know that it needs to be that big, really.
And the text is just the tiniest bit misaligned from each other (the "of 3" and the "1-2 of 5"), which I find really annoying.
The text input is that width because there are many projects that have huge quantities of resources. It's somewhat arbitrary that we've made it about 7 digits wide, but I've reduced it to be about 5 digits wide. I'm hesitant to match it to the thumbnail width: the pagination is a reusable element, and I'm not inclined to have that width customized across all its different contexts. I've refined the text alignment a bit, and it should appear more consistently vertically aligned.
Thanks, that looks better. I think it was just a bit too close to the thumbnail width to seem unintentional.
All themes look good now!