Incompatible with re-frame 1.1.2

[Peter Sagerson]

In re-frame 1.1.2, trim-v no longer sets the private coeffects key :re-frame.std-interceptors/untrimmed-event, instead setting the documented key :original-event. re-graph depends on the old key in re-graph.internals/re-graph-instance and throws exceptions with re-frame >= 1.1.2.

https://day8.github.io/re-frame/releases/2020/#112-2020-11-11

[Peter Sagerson]

This is an easy fix and I'm happy to send a pull request to look for both keys if you'd like. That's assuming you don't just want to move the re-frame dependency version all the way up.

[Oliver Hine]

Hi,

Thanks, that's a good catch. Did the upgrade to re-frame 1.1.2 break anything else in your codebase, i.e. is it a big upgrade? If not then I'm tempted to just bump the re-frame dependency and users should have no issues bumping it too.

Cheers

[Peter Sagerson]

You currently have a transitive dependency on reagent 0.7.0, which would bump to 0.10.0. This moves dom-related functions out of reagent.core and into reagent.dom. So technically that would be a breaking change, although a pretty minor one. Other than that, I've had no issues keeping current myself.

[Oliver Hine]

Hi @psagers,

I have pushed 0.1.15-SNAPSHOT to clojars. If you can confirm it works for you that would be really helpful, thank you.

Cheers

[Peter Sagerson]

Working for me, thanks!

[ålex]

Hi @oliyh, do we have any timeframe for releasing 0.1.15 or it's better to use snapshot for now? Proposed update works for me too.

[Oliver Hine]

Thanks for the confirmation @fmnoise, I have just released 0.1.15