oli107 / material-range-bar

Android widget for selecting a range of values.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

AndroidX Jetpack migration needed

anggrayudi opened this issue · comments

Well, I think we need to publish this library with AndroidX Jetpack ASAP. I checked so many dependencies on my project, and found that 3 of 19 dependencies are still using old Support Library. Material Range Bar is one of them. I am aware that this lib will cause crash to my app since Support Library has different package name with AndroidX Jetpack. We don't have to wait until stable version 1.0.0 is released by Google. We can do it now. I have tested AndroidX and found no problem with it.

Yes it cause crashes with this lib

commented

@TurKurT656 have you tried enableJetifier flag?

@TurKurT656 have you tried enableJetifier flag?

yes it was enabled.

commented

@anggrayudi @TurKurT656 Could you provide more info on the issue? Crash log, material-range-bar version, android gradle plugin/build tools version and so on
Particularly I use the library (1.4.5) along with androidx appcompat 1.0.2 and android gradle plugin 3.3.1 and default build tools version for this plugin.

android.enableJetifier=true
android.useAndroidX=true

are enabled too. I have tested our app on few android versions 18 to 28 and found no issues so far.
However, it is still vital for me know about any problems I could have missed before releasing the app to prod.
Could you confirm the library is crashing your apps even using the config provided by me?

@anggrayudi @TurKurT656 Could you provide more info on the issue? Crash log, material-range-bar version, android gradle plugin/build tools version and so on
Particularly I use the library (1.4.5) along with androidx appcompat 1.0.2 and android gradle plugin 3.3.1 and default build tools version for this plugin.

android.enableJetifier=true
android.useAndroidX=true

are enabled too. I have tested our app on few android versions 18 to 28 and found no issues so far.
However, it is still vital for me know about any problems I could have missed before releasing the app to prod.
Could you confirm the library is crashing your apps even using the config provided by me?

Today I've tested the newer version (1.4.5) with androidX and there is no error.