Change `.Time()` method on ULID to return time.Time, add `UnixMilli` for returning ms

Question

Change `.Time()` method on ULID to return time.Time, add `UnixMilli` for returning ms

tonyhb opened this issue a year ago · comments

Tony Holdstock-Brown commented a year ago

It's really common to write ulid.Time(id.Time()) when using ULIDs. It would make sense for .Time() to return a time.Time, and for UnixMilli() to return the timestamp as ms. This mirrors the time package and is more ergonomic.

Peter Bourgon · Answer 1 · Wed Aug 23 2023 20:22:30 GMT+0800 (China Standard Time)

I don't necessarily disagree, but this would represent a breaking change, which is probably a non-starter. What about adding a new method that returns time.Time, maybe Timestamp?