okigan / awscurl

Hello,

are there any plans to build arm64 images?

Does not work out if the box? (It’s python)On Oct 10, 2023, at 3:59 PM, Andrii Miroshnychenko ***@***.***> wrote: Hello, are there any plans to build arm64 images? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Unfortunately not, it does not work on AWS arm64 instances. We need to have arm64 base alpine image for that

Ah, I see - I’ll have a look, but PRs welcome 🤗 On Oct 10, 2023, at 8:20 PM, Andrii Miroshnychenko ***@***.***> wrote: Unfortunately not, it does not work on AWS arm64 instances. We need to have arm64 base alpine image for that —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

I guess the issue is here:

awscurl/.github/workflows/dockerhubpublish.yml

Lines 37 to 43 in e47119b

    
           - name: Build and push Docker image 
        
             uses: docker/build-push-action@v2 
        
             with: 
        
               context: . 
        
               push: true 
        
               tags: ${{ steps.meta.outputs.tags }} 
        
               labels: ${{ steps.meta.outputs.labels }}

We can have smth like this here:

      - name: Build and push
        uses: docker/build-push-action@v5
        with:
          context: .
          platforms: linux/amd64,linux/arm64
          push: true
          tags: user/app:latest

You can check here for more details: https://docs.docker.com/build/ci/github-actions/multi-platform/

try this: https://hub.docker.com/layers/okigan/awscurl/master/images/sha256-a33c2b5caa63d1bea13b10f372624b1052e0048f2247833421fba637a0a755fc?context=explore

changes in #184

@okigan works at my local macbook pro m2 (arm64). Testing with AWS cluster now.

@okigan works with AWS arm instances as well:

/ # which curl
/ # uname -a
Linux logstash-0 5.10.186-179.751.amzn2.aarch64 #1 SMP Tue Aug 1 20:51:46 UTC 2023 aarch64 Linux
/ # ps aux
PID   USER     TIME  COMMAND
    1 root      0:00 /bin/sleep infinity
   13 root      0:00 sh
   23 root      0:00 ps aux
/ # whoami
root

ok, merged and published, `docker pull okigan/awscurl` should get the right image for you

…

On Wed, Oct 11, 2023 at 2:57 PM Andrii Miroshnychenko < ***@***.***> wrote: @okigan <https://github.com/okigan> works with AWS arm instances as well: / # which curl / # uname -a Linux logstash-0 5.10.186-179.751.amzn2.aarch64 #1 SMP Tue Aug 1 20:51:46 UTC 2023 aarch64 Linux / # ps aux PID USER TIME COMMAND 1 root 0:00 /bin/sleep infinity 13 root 0:00 sh 23 root 0:00 ps aux / # whoami root — Reply to this email directly, view it on GitHub <#183 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADUYXTPAZUQKOETBUS45LLX6323RANCNFSM6AAAAAA526TJDU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

	- name: Build and push Docker image
	uses: docker/build-push-action@v2
	with:
	context: .
	push: true
	tags: ${{ steps.meta.outputs.tags }}
	labels: ${{ steps.meta.outputs.labels }}

arm64 image support