Giters

oivoodoo / devise_masquerade

Extension for devise, enable login as functionality. Add link to the masquerade_path(resource) and use it.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Is the `resource` param being used in `after_back_masquerade_path_for` ?

sushant12 opened this issue · comments

commented

https://github.com/oivoodoo/devise_masquerade/blob/master/app/controllers/devise/masquerades_controller.rb#L120
I guess the resource param is not being used, so why have it right? I looked into the spec and no resource was passed into the after_back_masquerade_path_for, so I guess better to remove it?

Let me know what you think and I will submit a PR.

commented

Hi @sushant12

I would suggest leave it as it is. the main reason to have resource there that everyone can override this method with passed owner user. also in case if we delete it now it could break the functionality as well.