#{name}_masquerade_owner is broken

Question

#{name}_masquerade_owner is broken

ilya-konanykhin opened this issue 2 years ago · comments

Looks like #{name}_masquerade_owner is broken. It always tries to find a resource by GlobalID: https://github.com/oivoodoo/devise_masquerade/blob/master/lib/devise_masquerade/controllers/helpers.rb#L53-L63

However, when the owner resource ID is being written, it is GlobalID only when using cache, when using session it is plain to_param: https://github.com/oivoodoo/devise_masquerade/blob/master/app/controllers/devise/masquerades_controller.rb#L168-L175

Or maybe I'm missing something?

Alex · Answer 1 · Tue Oct 25 2022 14:35:01 GMT+0800 (China Standard Time)

Hi @ilya-konanykhin . everything is reasonable, going to apply the patch during the day. session/cache changes were applied fast enough by me and I missed it. thank you for the report!

Alex · Answer 2 · Tue Oct 25 2022 18:27:17 GMT+0800 (China Standard Time)

Hi @ilya-konanykhin please give a try 2.0.2 if it works for you. thank you!

Ilya Konanykhin · Answer 3 · Tue Oct 25 2022 22:52:35 GMT+0800 (China Standard Time)

Thanks a lot @oivoodoo that fixed it! However I think there's another bug, let me investigate and create another issue ticket.

Ilya Konanykhin · Answer 4 · Tue Oct 25 2022 23:09:33 GMT+0800 (China Standard Time)

However I think there's another bug, let me investigate and create another issue ticket.

Nevermind, it's just us using your code the way it wasn't intended to be used. Thanks again for fixing the bug!

Alex · Answer 5 · Tue Oct 25 2022 23:10:08 GMT+0800 (China Standard Time)

@ilya-konanykhin thank you!