ohsu-comp-bio / g2p-aggregator

Associations of genomic features, drugs and diseases

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

intuitive search

ahwagner opened this issue · comments

we need to restructure and/or better document the search functionality for users landing on the site. One potential option is to do de-emphasize (remove?) the free-text search bar, and preset a bunch of empty filters for the various components: drug, gene, variant, etc.

Another is to make clearer documentation and make it a clearer, more attractive starting point. My personal preference is for both.

commented

@ahwagner Please review - I'll make a public instance available for review, hopefully by 2/4

Proposed changes

image

Refactored search

Default operator now and was or

Current

image

Proposed

image

Refactored table

Current

image

Proposed

image

@bwalsh proposed changes look good to me.

Some additional changes we should implement:

  • ensure source_url field URLs are presented as hyperlinks
    image
  • point the help documentation hyperlink in the intro paragraph to docs.cancervariants.org.
  • add brca to the list of excluded sources on the paper filter
  • fix auto-sort on evidence level
  • reduce filter drop-down menu options to preferentially sort or only display "short labels"

@bwalsh added some feedback from our call today to this issue.

commented

@ahwagner

I've updated the staging site at 35.165.177.191.
The items checked off above have been addressed.
A new bucket with the data is available at https://s3-us-west-2.amazonaws.com/g2p-0.12/index.html
The drop-down menu options cannot be shortened. However, I have ensured that a filtered short lable eg evidence_lable does filter the results.

Let me know your thoughts

image

These changes all look good. It appears that the "response" column broke, however; even records containing response_type data lack content in the relabeled column.

@bwalsh did you have a chance to look at comment above?

commented

Okay. I'm getting a weird error on my end–it looks like many of the columns are now broken, as is one of the interactive heatmaps.

image

commented

Fantastic. I'm going to bump this to production for co-author review, with the caveat that the Table 2 p. normalization (this issue) isn't yet completed.

Requests for JSON data from https://s3-us-west-2.amazonaws.com/g2p-0.12/index.html (e.g. https://s3-us-west-2.amazonaws.com/g2p-0.12/civic.json) return Access Denied errors. @bwalsh could you take a look at this?

commented

@ahwagner fixed. thanks for the catch