Giters

ohmyzsh / ohmyzsh

🙃 A delightful community-driven (with 2,300+ contributors) framework for managing your zsh configuration. Includes 300+ optional plugins (rails, git, macOS, hub, docker, homebrew, node, php, python, etc), 140+ themes to spice up your morning, and an auto-update tool so that makes it easy to keep up with the latest updates from the community.

Home Page:https://ohmyz.sh

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Typo found in templates/zshrc.zsh-template comments

FriendlyNeighborhoodSpiderLAN opened this issue · comments

commented

Describe the bug

I recently found a weird spelling at templates/zshrc.zsh-template

Here :

# Preferred editor for local and remote sessions
# if [[ -n $SSH_CONNECTION ]]; then
#   export EDITOR='vim'
# else
#   export EDITOR='mvim'
# fi

as you can see the second editor is mvim ,i think it's a typo
and should be nvim instead ...

(the only related editor i found to mvim was macvim which is obviously
built for MacOS not linux distros)

and this may cause issues when people are uncommenting this section
they may not see it has wrong spelling ...

Steps to reproduce

  1. make sure you have zsh installed
  2. read .zshrc or zshrc.zsh-template like such :
    cat -n /home/FOO/.zshrc
    or
    cat -n /home/FOO/ohmyzsh/templates/zshrc.zsh-template
  3. you'll see typo at line 88
  4. so if it was supposed to be nvim change the mvim to nvim

NOTE : this typo originates from /home/FOO/ohmyzsh/templates/zshrc.zsh-template
so to solve the problem the main template must be fixed.

Expected behavior

I expect there be nvim instead of mvim

many people will not observe the issue when uncommenting this section
for the sake of usage

but rather after getting errors they know they must change mvim to nvim,

Screenshots and recordings

No response

OS / Linux distribution

Linux/Debian

Zsh version

5.6

Oh My Zsh version

master (bf30396)

Terminal emulator

Terminator

If using WSL on Windows, which version of WSL

None

Additional context

No response

commented

What makes you think MacOS users are not also using OMZ?

commented

Hey, thanks for the idea! Actually, that's more an "idea" of what to do in zshrc, it shouldn't be an issue to leave it as is.
Thanks!