Need MR test to verify compatibility at the 1.5 boundary
bturrubiates opened this issue · comments
Ben Turrubiates commented
Just today we discovered some issues in our 1.5 support around the MR mode. Unfortunately, it's a bit tricky to get right. I think we need a test that will verify that providers are handling the conversion as expected.
Otherwise, the providers will go untested and bugs will lurk. The behavior should be the same for all providers.
Some cases to check for:
- When an application is compiled with 1.5 and requests 1.4, the provider should understand
FI_MR_UNSPEC
. - Proper handling of
FI_MR_BASIC
- Providers in 1.5 support the translation of
FI_MR_BASIC
->FI_MR_LOCAL | OFI_MR_BASIC_MAP
(if they supportedFI_MR_BASIC
).
etc.
Sean Hefty commented
We have the 1.4 version of fabtests. Those need to be run against the 1.5 release. The 1.4 fabtests should run after being built against libfabric 1.4, and also after being built against libfabric 1.5. The 1.5 fabtests target the 1.5 api updates, and should be part of the testing.
I'm not sure we need new tests, versus just needing to run the standard test process that we do for each release.
Sean Hefty commented
The unit test fi_getinfo_test checks for v1.0 and v1.5+ mr_mode bits and correct interpretation of them.