make dist failure in fabtests

Question

make dist failure in fabtests

a-ilango opened this issue 7 years ago · comments

Our internal CI picked up a failure in make dist command when building fabtests after the following commit:
1eab4d4

Error logs:

make  dist-bzip2 dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory `/home/build/buildstore-upstream/psm-rhel7/fabtests/03'
make[1]: *** No rule to make target `common/ft_osd.h', needed by `distdir'.  Stop.
make[1]: Leaving directory `/home/build/buildstore-upstream/psm-rhel7/fabtests/03'
make: *** [dist] Error 2
program finished with exit code 2
elapsedTime=0.042616

cc: @gladkovdmitry17

Sean Hefty · Answer 1 · Thu Apr 20 2017 06:33:16 GMT+0800 (China Standard Time)

We will likely need to do something similar to what libfabric does:
https://github.com/ofiwg/libfabric/blob/master/Makefile.am#L59
I didn't notice the osd.h files referenced in the makefile.am. Maybe they need to be added to extra_dist? (I hate this packaging stuff.)

Jeff Squyres · Answer 2 · Thu Apr 20 2017 06:36:01 GMT+0800 (China Standard Time)

All sources need to be listed in makefile.am one way or another. Sent from my phone. No type good.

arun ilango · Answer 3 · Thu Apr 20 2017 06:41:28 GMT+0800 (China Standard Time)

Maybe they need to be added to extra_dist?

Adding the file in EXTRA_DIST fixes the issue. I think that's where it should have been added in the first place. I'll submit a PR for this.

arun ilango · Answer 4 · Thu Apr 20 2017 07:42:36 GMT+0800 (China Standard Time)

I've added the header file in sources and not EXTRA_DIST. Also moved other header files that were in EXTRA_DIST to sources. This is to mirror the behavior in libfabric. The issue with ft_osd.h was incorrect path.