Tests need to limit exit codes to range 0-255
shefty opened this issue · comments
Someone please correct me if I'm wrong, but it appears that linux only supports exit codes in the range of 0-255. Most or all of the fabtests return a positive fabric errno at the conclusion of a test. The result is that the error value may be mapped to the wrong exit code, or in the case of FI_EOTHER (256) back to 0, which is success!
Yes, the tests don't follow linux exit code requirements. We use the return code in runfabtests.sh to determine if the test needs to be marked as failed or not run (-FI_ENODATA) which unfortunately doesn't map to linux exit code meanings.
Probably best to limit exit code to 0 or 1 and make the failing return value available via some log output.
See PR #597