Download button missing from messages with more than one attachment
jacobaul opened this issue · comments
Impacted versions:17.0
Steps to reproduce: Create a chatter message with multiple attachments in a single message
Current behavior: Other users see only the delete button on the chatter messages. A CSS class is missing on the attachment card to show both the download button and the delete button together. The result is that even the the user should be able to download the attachment, there is no way to do so without using the browser's dev tools to see the hidden HTML.
Expected behavior: The download button appears on the attachment card in the chatter message, including for messages with more than one attachment.
The offending commit appears to be this one.
The issue is that the attachment.isDeletable disagrees with showDelete in this div.
The result is that it does not add the 'o-hasMultipleActions d-flex flex-column' classes, even thought the delete button is rendered. This breaks the HTML and overlays the delete button on top of the download button. This is only true for multiple attachments due to the check in showDelete on the number of attachments
Hello @jacobaul, thanks for reporting this issue !
I've linked a pull request that will solve the problem once deployed. It should be available on Monday.
Have a nice day ! 🙂
Hello @jacobaul, sorry for the late follow up !
I linked a pull request that was merged yesterday and fixes the encountered issue. The fix will be available on Monday on your database.
Thanks for your patience and I wish you a great weekend 🙂