use DockerImage from ENV variable
ashish0x02 opened this issue · comments
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
please update hardcoded image to use configurable image tags.
https://github.com/keyval-dev/odigos/blob/de3daf79e33f1f5ff8e5f97c3134aaeed01d6811/autoscaler/controllers/gateway/deployment.go#L24
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
it will become a blocker to many orgs whose workload is 500+ nodes and which are using private ECR repo(it will throw Docker rate limit error)
Additional context
Add any other context or screenshots about the feature request here.
Hi @ashish0x02
We currently have a flag named --image-prefix which you can use during installation to use private image repos instead of docker hub.
is it kind of env variable which I need to pass as k8s ENV during run time?
is it kind of env variable which I need to pass as k8s ENV during run time?
You can set it when you run odigos install.
Reference: https://docs.odigos.io/cli/odigos_install#options
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.
Hi @ashish0x02
Can you please share if this is resolved or you still need help with this issue?
Please note that we recently upgraded the collector image to use v0.91.0.
If you need to use a different docker registry than dockerhub, you can use the --image-prefix as described above.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.
This issue was closed because it has been stale for 30 days with no activity.