octopitus / rn-sliding-up-panel

Draggable sliding up panel implemented in React Native https://octopitus.github.io/rn-sliding-up-panel/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Pan handler is not being correctly released

lukemcgregor opened this issue · comments

Pan handler is not being correctly released

When the pan handler is supposed to release its actually not releasing. This is because the onPanResponderRelease is returning falsey values.

Steps to Reproduce / Code Snippets / Screenshots

  • Add a slide up panel
  • set minimumDistanceThreshold={0.9} (or something big so you can see it)
  • open the menu once, not that the grab takes a significant distance to capture
  • open the menu a second time, not that the grab is instantly captured

The grab is still captured from the previous open on the second one (it should grab at the same point on subsequent opens). This also messes up other gesture responders in the area. I will follow this with a PR to resolve the issue.


Environment

  • Version: 2.4
  • React Native version: 0.62
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): Sim, 13.6, debug