Giters

octomation / makefiles

🗂 Set of useful Makefiles.

Home Page:https://makefiles.octolab.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

tools-update didn't work properly

kamilsk opened this issue · comments

commented

at go-service:

$ make update
...
$ git diff tools/go.mod
-       github.com/golangci/golangci-lint v1.37.1
+       github.com/golangci/golangci-lint v1.38.0

but expected

$ make update
...
$ git diff tools/go.mod
-       github.com/golangci/golangci-lint v1.37.1
-       github.com/grpc-ecosystem/grpc-gateway/v2 v2.2.0
+       github.com/golangci/golangci-lint v1.38.0
+       github.com/grpc-ecosystem/grpc-gateway/v2 v2.3.0
-       google.golang.org/protobuf v1.25.0
+       google.golang.org/protobuf v1.25.1-0.20201208041424-160c7477e0e8

so, why it's happening as above?

commented

maybe it's happening because I also depend on google.golang.org/protobuf v1.25.0
in this case it try to find that version of github.com/grpc-ecosystem/grpc-gateway/v2 which compatible with the version of protobuf.

commented

Also I have a lot of indirect deps (go-service) and one for go-tool:

require (
	github.com/golang/mock v1.5.0
	github.com/golangci/golangci-lint v1.38.0
	github.com/kyoh86/looppointer v0.1.7
	golang.org/x/exp v0.0.0-20210220032938-85be41e4509f
	golang.org/x/text v0.3.4 // indirect
	golang.org/x/tools v0.1.0
)