[BUG]: getReviews returns in chronological order with no etag update
KastenMike opened this issue · comments
What happened?
pullRequests.getReviews returns in chronological order while pullRequests.getAll is reverse chronological. Is there a reason for this?
If you make use of etags and had per_page: 1 but add a new review, the new review would never be found due to 304 errors. Whereas with pullRequests.getAll, the most recent 1 is first and it seems any change triggers all etags to change (re-opening a PR on page 3 seems to trigger page 1 etag to also change)
The fact that getReviews includes decisions and all the comments makes the pagination risk higher. Whereas getComments (which has a sort option) includes only the comments but no review decisions...it wouldn't be so bad if getReviews would return only the review decisions and not all the comments already covered by getComments but still, a sort option would be better if @gr2m knows someone who works on the backend for these API calls
Versions
^15.8.2
Relevant log output
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀